Merged
Conversation
DOsinga
approved these changes
Oct 24, 2025
|
|
||
| const fetchExtensions = useCallback(async () => { | ||
| await getExtensions(true); | ||
| }, [getExtensions]); |
Collaborator
There was a problem hiding this comment.
why wrap this in a callback? we can just call getExtensions where it is needed, no?
| const extensions = useMemo(() => { | ||
| if (extensionsList.length === 0) { | ||
| return []; | ||
| } |
Collaborator
There was a problem hiding this comment.
I don't think checking this gets you anything
| } | ||
| return a.enabled ? -1 : 1; | ||
| }); | ||
| }, [filteredExtensions]); |
Collaborator
There was a problem hiding this comment.
we seem to have two sorts going on here. let's combine them into one. also the first sort looks at bundled which I don't think really gives us anything. if we wanted to do this, prioritize anything that is of type {Builtin, Platform, Frontend} I would say
| msg: `Failed to ${extensionConfig.enabled ? 'disable' : 'enable'} ${extensionConfig.name}`, | ||
| traceback: error instanceof Error ? error.message : String(error), | ||
| }); | ||
| await fetchExtensions(); |
Collaborator
There was a problem hiding this comment.
hmm, do we want to do this in the error clause? if it failed on 67 it will fail again. why do we need to fetch extensions again anyway?
| extension: Extension; | ||
| isEnabled: boolean; | ||
| onToggle: (enabled: boolean) => void; | ||
| } |
Collaborator
There was a problem hiding this comment.
Let's flatten this. I also would drop the description. this is a compact view and the descriptions hardly ever add anything anyway
Collaborator
Author
There was a problem hiding this comment.
my bad this wasn't even used after I refactored things, removed
…ithub.com:block/goose into zane/next-camp/chat-extension-toggle * 'main' of github.com:block/goose: (re)Standardize Session Name Attribute (#5279) * 'zane/next-camp/chat-extension-toggle' of github.com:block/goose:
- Add error handling for extension fetch failures - Add autofocus to search input for better UX - Reset search query when dropdown closes
- Remove empty array check in extensions memo - Combine sorting logic and prioritize by type (builtin/platform/frontend) - Flatten extension item view and remove descriptions for compact display - Remove unused imports (getSubtitle, getExtensions)
wpfleger96
added a commit
that referenced
this pull request
Oct 24, 2025
* main: Add bottom menu extension selection (#5352)
BlairAllan
pushed a commit
to BlairAllan/goose
that referenced
this pull request
Oct 25, 2025
Signed-off-by: Blair Allan <Blairallan@icloud.com>
michaelneale
added a commit
that referenced
this pull request
Oct 26, 2025
* main: fixing typo in blog metadata (#5382) feat: add new blog entry on adopting Goose in the enterprise (#5381) Blog/acp intro oct 2024 (#5379) feat: add A/B test framework generator recipe (#5378) Doc: (blog) - Deep Dive into goose's Extension System and Model Context Protocol (MCP) (#5291) Some system prompt tidying (#5313) Fix scheduler jobs dates formatting (#5368) Use Instructions as Prompt in Scheduler (#5359) feat(snowflake): add support for newer Claude 4.5 and 4 models (#5350) Add bottom menu extension selection (#5352) (re)Standardize Session Name Attribute (#5279) chore: improve timeout for entering password when running goose ui from source (#5349)
michaelneale
added a commit
that referenced
this pull request
Oct 26, 2025
* main: fixing typo in blog metadata (#5382) feat: add new blog entry on adopting Goose in the enterprise (#5381) Blog/acp intro oct 2024 (#5379) feat: add A/B test framework generator recipe (#5378) Doc: (blog) - Deep Dive into goose's Extension System and Model Context Protocol (MCP) (#5291) Some system prompt tidying (#5313) Fix scheduler jobs dates formatting (#5368) Use Instructions as Prompt in Scheduler (#5359) feat(snowflake): add support for newer Claude 4.5 and 4 models (#5350) Add bottom menu extension selection (#5352) (re)Standardize Session Name Attribute (#5279) chore: improve timeout for entering password when running goose ui from source (#5349)
michaelneale
added a commit
that referenced
this pull request
Oct 27, 2025
* main: (54 commits) fixing typo in blog metadata (#5382) feat: add new blog entry on adopting Goose in the enterprise (#5381) Blog/acp intro oct 2024 (#5379) feat: add A/B test framework generator recipe (#5378) Doc: (blog) - Deep Dive into goose's Extension System and Model Context Protocol (MCP) (#5291) Some system prompt tidying (#5313) Fix scheduler jobs dates formatting (#5368) Use Instructions as Prompt in Scheduler (#5359) feat(snowflake): add support for newer Claude 4.5 and 4 models (#5350) Add bottom menu extension selection (#5352) (re)Standardize Session Name Attribute (#5279) chore: improve timeout for entering password when running goose ui from source (#5349) Fix legacy import (#5343) Unify loading goose messages and usechatstream determines chat state (#5306) Docs: goose session export and goose session import (#5267) Create recipe dir on save (#5337) docs: Update Discord link (#5335) [recipe workflow]: Fix `Invalid revision range` error (#5334) Add tech-article-explainer recipe (#5333) doc: added beta banner for old blog post (#5332) ...
katzdave
added a commit
that referenced
this pull request
Oct 28, 2025
…message * 'main' of github.com:block/goose: Add bottom menu extension selection (#5352)
10 tasks
BlairAllan
pushed a commit
to BlairAllan/goose
that referenced
this pull request
Nov 29, 2025
Signed-off-by: Blair Allan <Blairallan@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added bottom menu extension selector gated by ALPHA flag for upcoming work